Fix crash on Add Physical Disk (#8)#24
Open
Prowler1000 wants to merge 2 commits intoTalAloni:masterfrom
Open
Conversation
Catch IO exceptions that are a result of Windows system error code 32 "The process cannot access the file because it is being used by another process." as this is seems to be the expected behavior for system disks. Online status will be set to "Unknown" in this event. Rethrow IO exceptions that are not a result of error 32.
Author
|
Sorry this took me so long to do, I got myself hyperfocused on other projects and eventually, it had been so long that I started avoiding working on this fix. Decided I'd get it done this evening and, while I haven't done any extensive testing, everything seems to work as expected on my device. |
Owner
|
The "EndsWith" is very inelegant, even without trying to understand the problem I can tell I don't like the solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems as though #8 was the result of system drives (like the drive your OS is on) being in use when attempting to check the online status. I've added handling for the case of this specific error, but it does not discriminate between system drives and non-system drives. When loading the physical disk form, we catch IOExceptions from GetOnlineStatus, check if they're a result of system error 32, and set the status to "Unknown" as opposed to "Online" or "Offline". If the exception is not because of system error 32, we rethrow the exception