**Title:** feat(rate-limit): cap per-provider queue depth with reject-on-overflow#588
Open
SHEROSE0 wants to merge 2 commits into
Open
**Title:** feat(rate-limit): cap per-provider queue depth with reject-on-overflow#588SHEROSE0 wants to merge 2 commits into
feat(rate-limit): cap per-provider queue depth with reject-on-overflow#588SHEROSE0 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closes #409
Description:
This PR implements a configurable queue depth cap to prevent unbounded memory accumulation when upstream providers are persistently slower than the refill rate.
Changes:
maxQueueDepthvalidation insrc/rateLimit.ts. Requests exceeding this limit now immediately reject withRATE_LIMIT_QUEUE_CAP_EXCEEDEDinstead of queueing indefinitely.src/webhookMetrics.tsto track rejections for better observability.src/rateLimit.test.tsusing fake timers to verify FIFO processing and hard rejection limits.Security & Stability:
Acceptance Criteria Checklist:
maxQueueDepthapplied per provider.QUEUE_CAP_EXCEEDED.#closes