fix: broken defaultDocs properties
#301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DogPawHat is attempting to deploy a commit to the Tanstack Team on Vercel. A member of the Team first needs to authorize it. |
❌ Deploy Preview for tanstack failed.
|
DogPawHat
commented
Nov 15, 2024
| import { Library } from '.' | ||
|
|
||
| export const configProject: Library = { | ||
| export const configProject = { |
Contributor
Author
There was a problem hiding this comment.
satisfies is generally nicer but I'm aware that it's slower then doing the explicit typing. willing to revert.
Contributor
Author
There was a problem hiding this comment.
wait, this is application code not a library. I think it's fine then.
SeanCassiere
approved these changes
Nov 22, 2024
SeanCassiere
changed the title
defaultDocs propertiesdefaultDocs properties
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #300