Skip to content

Conversation

@SeanCassiere
Copy link
Member

@SeanCassiere SeanCassiere commented Jan 28, 2025

This adds in the functionality of having the links in the table of contents have their styling change based on whether it's corresponding heading is visible on the screen.

See the screenshots below. Both screenshots were taken by visiting /router/latest/docs/framework/react/guide/file-based-routing (both locally and on the current version of the website) and having scrolled down just a bit so that the title of "/s or .s?" is touching the top of the browser.

Before:

image

After:

image

@netlify
Copy link

netlify bot commented Jan 28, 2025

Deploy Preview for tanstack ready!

Name Link
🔨 Latest commit 9bf7271
🔍 Latest deploy log https://app.netlify.com/sites/tanstack/deploys/679b247c67ceba000874b56a
😎 Deploy Preview https://deploy-preview-338--tanstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 47 (🔴 down 17 from production)
Accessibility: 95 (no change from production)
Best Practices: 83 (🔴 down 9 from production)
SEO: 77 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@SeanCassiere SeanCassiere marked this pull request as ready for review January 30, 2025 05:21
@tannerlinsley tannerlinsley merged commit 59d02bd into main Jan 30, 2025
2 checks passed
@tannerlinsley tannerlinsley deleted the reactive-doc-sidebar-links branch January 30, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants