feat(react-virtual): add useFlushSync option #1100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0c8a499 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
View your CI Pipeline Execution ↗ for commit 0c8a499
☁️ Nx Cloud last updated this comment at |
4 tasks
channyeintun
approved these changes
Dec 31, 2025
channyeintun
left a comment
channyeintun
left a comment
There was a problem hiding this comment.
Agreed — the solution is pretty straightforward and the implementation is clean. Nice work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Adds a React-specific configuration flag (useFlushSync) to @tanstack/react-virtual to control whether flushSync is used for synchronous scroll correction during measurement.
flushSync is intentionally used to limit visible whitespace during fast scrolling with dynamically measured items. In React 19 this triggers a warning when called from useLayoutEffect, but the warning itself does not affect correctness in this case.
Instead of changing the default behavior to silence the warning, this PR makes the behavior explicit and opt-out:
This keeps backward compatibility while allowing React 19 users to opt out if desired.
✅ Checklist
pnpm run test:pr.🚀 Release Impact