feat: Add react@19 to supported peer deps #893
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 08f147e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
RobinMalfait
pushed a commit
to tailwindlabs/headlessui
that referenced
this pull request
Dec 12, 2024
`@tanstack/react-virtual` added peer deps support for React 19 in [v3.11.0](https://github.com/TanStack/virtual/releases/tag/v3.11.0) (TanStack/virtual#893) This PR upgrades the packages. This can resolve some warnings on some React 19 projects, e.g.: ``` npm warn ERESOLVE overriding peer dependency npm warn While resolving: @tanstack/react-virtual@3.10.9 npm warn Found: react@19.0.0 npm warn node_modules/react npm warn peer react@"^18 || ^19 || ^19.0.0-rc" from @headlessui/react@2.2.0 npm warn node_modules/@headlessui/react npm warn @headlessui/react@"^2.2.0" from the root project npm warn 15 more (@floating-ui/react, @floating-ui/react-dom, ...) npm warn npm warn Could not resolve dependency: npm warn peer react@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9 npm warn node_modules/@headlessui/react/node_modules/@tanstack/react-virtual npm warn @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0 npm warn node_modules/@headlessui/react npm warn npm warn Conflicting peer dependency: react@18.3.1 npm warn node_modules/react npm warn peer react@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9 npm warn node_modules/@headlessui/react/node_modules/@tanstack/react-virtual npm warn @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0 npm warn node_modules/@headlessui/react npm warn ERESOLVE overriding peer dependency npm warn While resolving: @tanstack/react-virtual@3.10.9 npm warn Found: react-dom@19.0.0 npm warn node_modules/react-dom npm warn peer react-dom@"^18 || ^19 || ^19.0.0-rc" from @headlessui/react@2.2.0 npm warn node_modules/@headlessui/react npm warn @headlessui/react@"^2.2.0" from the root project npm warn 5 more (@floating-ui/react, @floating-ui/react-dom, ...) npm warn npm warn Could not resolve dependency: npm warn peer react-dom@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9 npm warn node_modules/@headlessui/react/node_modules/@tanstack/react-virtual npm warn @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0 npm warn node_modules/@headlessui/react npm warn npm warn Conflicting peer dependency: react-dom@18.3.1 npm warn node_modules/react-dom npm warn peer react-dom@"^16.8.0 || ^17.0.0 || ^18.0.0" from @tanstack/react-virtual@3.10.9 npm warn node_modules/@headlessui/react/node_modules/@tanstack/react-virtual npm warn @tanstack/react-virtual@"^3.8.1" from @headlessui/react@2.2.0 npm warn node_modules/@headlessui/react ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.