Skip to content

Conversation

@piecyk
Copy link
Collaborator

@piecyk piecyk commented Mar 13, 2025

The issue here was that rage was changed by getVirtualIndexes but that was not updating cache in maybeNotify that was it was not calling the notify.

Fixes #871

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

⚠️ No Changeset found

Latest commit: f9e5bb8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud
Copy link

nx-cloud bot commented Mar 13, 2025

View your CI Pipeline Execution ↗ for commit ce47261.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 27s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-13 20:06:58 UTC

@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 13, 2025

Open in Stackblitz

More templates

@tanstack/angular-virtual

npm i https://pkg.pr.new/@tanstack/angular-virtual@957

@tanstack/lit-virtual

npm i https://pkg.pr.new/@tanstack/lit-virtual@957

@tanstack/solid-virtual

npm i https://pkg.pr.new/@tanstack/solid-virtual@957

@tanstack/react-virtual

npm i https://pkg.pr.new/@tanstack/react-virtual@957

@tanstack/svelte-virtual

npm i https://pkg.pr.new/@tanstack/svelte-virtual@957

@tanstack/virtual-core

npm i https://pkg.pr.new/@tanstack/virtual-core@957

@tanstack/vue-virtual

npm i https://pkg.pr.new/@tanstack/vue-virtual@957

commit: ce47261

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

react-virtual – Visible items are incorrect on first render when using max-height on container

1 participant