Deposit 2026-07-16 batch 4: deadline call-graph, abandon-vs-cancel, serverless keep-alive, hollow-green, partial rollout, shared primitive#63
Merged
Conversation
…sibling hops exposed
… swallowing both hides a regression
…branch is hollow-green
…affic caller on the old behavior
…ive - fix it once with a guard test
TapeshN
marked this pull request as ready for review
July 16, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six generalizable engineering learnings from a fix-round re-review and a design-primitive
consolidation, paraphrased to strip all client/product/repo identifiers.
guardrails/a-deadline-guarding-one-hop-of-a-fail-closed-path-leaves-sibling-hops-exposed.mdguardrails/a-client-side-timeout-abandons-a-query-without-cancelling-it.mdguardrails/a-serverless-keep-alive-primitive-throws-for-two-reasons-swallowing-both-hides-a-regression.mdevals/a-test-environment-that-can-only-reach-a-primitives-fallback-branch-is-hollow-green.mdguardrails/a-partial-rollout-of-a-fix-commonly-skips-the-highest-traffic-caller.mdguardrails/recurring-per-surface-ui-drift-is-a-missing-shared-primitive-fix-it-once-with-a-guard-test.mdOne entry per commit, per the schema. A seventh source bullet (an internal merge-automation
policy change) was intentionally held back as org-internal process, not a generalizable
engineering lesson.
Test plan
tools/strata/scrub.py(blocklist-gated) run on the raw source bullets AND each of the6 paraphrased files individually AND combined — CLEAN (0 matches) in every pass
.github/scripts/validate_entries.py— all entries valid across 9/9 categories, no newwarnings introduced by this batch
.github/scripts/strata_guard.py— PASSED, both with and withoutSTRATA_BLOCKLISTpopulated from the real local blocklist (full proprietary-term check)
entries (a choke-point/enumerate-callers entry, and a design-review-primitive entry) but
each covers a distinct angle (highest-traffic-caller specifically; mechanical guard-test
as the recurrence fix specifically) so were kept rather than folded
Draft only — awaiting coordinator review + merge per current operator policy.