feat: add option to disable effect#545
Open
ChickenPige0n wants to merge 1 commit intoTeamFlos:mainfrom
Open
Conversation
Member
|
能试试和autoplay放一起吗 |
渲染代码是这么写的，直接改动可能破坏兼容性，或者堆if史山（（ |
Comment on lines
+47
to
+48
| item-disable-effect = Disable Shader Effect | ||
| item-disable-effect-sub = You can turn on this option if you experience lag when playing a chart with shader effects. |
Member
There was a problem hiding this comment.
- item-disable-effect = Disable Shader Effect
- item-disable-effect-sub = You can turn on this option if you experience lag when playing a chart with shader effects.
+ item-shader-effect = Shader Effect
+ item-shader-effect = You can turn off this option if you experience lag when playing a chart with shader effects.我们应该用双重否定句吗？我觉得描述为“着色器效果”，然后值默认为开，这样会符合直觉一点
Member
There was a problem hiding this comment.
虽然config里确实是disable_effect,但我觉得给用户呈现的要符合直觉一点？不一定和内部实现相同。
Comment on lines
+47
to
+48
| item-disable-effect = 禁用着色器效果 | ||
| item-disable-effect-sub = 如果你在播放包含着色器效果的谱面时遇到卡顿，可以开启此选项以提升流畅度。 |
Member
There was a problem hiding this comment.
- item-disable-effect = 禁用着色器效果
- item-disable-effect-sub = 如果你在播放包含着色器效果的谱面时遇到卡顿，可以开启此选项以提升流畅度。
+ item-shader-effect = 着色器效果
+ item-shader-effect-sub = 如果你在播放包含着色器效果的谱面时遇到卡顿，可以关闭此选项以提升流畅度。同上
| } | ||
| item! { | ||
| render_title(ui, tl!("item-disable-effect"), Some(tl!("item-disable-effect-sub"))); | ||
| render_switch(ui, rr, t, &mut self.disable_effect_btn, config.disable_effect); |
Member
There was a problem hiding this comment.
这样这里就应该用!config.disable_effect了，虽然内部实现有点怪，但是用起来可能更符合直觉？
Contributor
|
需要内部讨论一下公平性问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #541
