Remember and restore orientation on fullscreen exit #12781
Merged
+21
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Store the original screen orientation when entering fullscreen. - Restore the saved orientation when exiting fullscreen. - On tablets, continue to just toggle the fullscreen UI without changing the device orientation.
AudricV
added
the
template ignored
TobiGr
added
bug
4 tasks
TobiGr
reviewed
Nov 29, 2025
Contributor
TobiGr
left a comment
TobiGr
left a comment
There was a problem hiding this comment.
Thank you for the PR. The code LGTM.
I am pretty certain that this code was that simple years ago but was changed to achieve certain behaviour for some edge cases.
We need to test this with landscape and portrait videos (and switching between them) as well as locking the orientation while playing videos on phone, tablet and tv to check for unwanted behaviours.
app/src/main/java/org/schabi/newpipe/fragments/detail/VideoDetailFragment.java
Outdated
Show resolved
Hide resolved
5 tasks
TobiGr
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
Before/After Screenshots/Screen Record
Fixes the following issue(s)
Relies on the following changes
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence