Skip to content

옛 서비스명 산문 표기를 core·renderer 로 정리#4

Merged
m-a-king merged 1 commit into
mainfrom
chore/prose-service-names
Jul 11, 2026
Merged

옛 서비스명 산문 표기를 core·renderer 로 정리#4
m-a-king merged 1 commit into
mainfrom
chore/prose-service-names

Conversation

@m-a-king

@m-a-king m-a-king commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Situation

  • repo 이름 변경(PIKI-Server 는 core, PIKI-HeadlessBrowser 는 renderer)이 있었지만, 이 repo 는 호출자와 이웃 서비스를 자주 언급하는 특성상 CLAUDE.md·README·docs·Java 주석에 옛 이름이 68곳 남아 있었습니다.

Task

  • 산문의 옛 이름 표기를 새 이름으로 정리하고, README 의 옛 org 링크도 갱신합니다. 기능과 telemetry 값은 건드리지 않습니다.

Action

  • 27개 파일 56줄을 치환했습니다: PIKI-Server 는 core, PIKI-Extractor 는 extractor, PIKI-HeadlessBrowser 는 renderer. README 의 관련 repo 링크도 depromeet/PIKI-Server 에서 TeamPiKi/core 로 갱신했습니다.
  • renderer 는 private repo 라 링크 없이 텍스트만 바꿨습니다.
  • application.yml(main·test)의 옛 이름 주석 7곳은 남겼습니다: telemetry rename 작업이 같은 파일을 만지는 중이라 충돌 회피. docs/api-contract.md 의 메트릭 라벨 리터럴(application=piki-extractor)은 실측값이라 유지했습니다.

Result

  • 잔존 grep 으로 옛 이름이 application.yml 뿐임을 확인했고, Java·yml diff 추가 라인이 전부 주석임을 기계 검사로 확인했습니다. 코드 로직 라인 변경 0.

연관 이슈

Summary by CodeRabbit

  • Documentation

    • Updated service, API contract, integration, and development guidance terminology to reflect the current core and renderer architecture.
    • Refreshed repository references, ownership descriptions, caller responsibilities, and endpoint documentation.
    • Clarified storage, extraction, error-handling, timeout, and observability contract descriptions.
  • Chores

    • Updated related comments across build, CI, production, and test code.
    • No runtime behavior, APIs, configuration values, or test logic changed.

- org 이관·repo 소문자화(PIKI-Server→core, PIKI-Extractor→extractor, PIKI-HeadlessBrowser→renderer)에 맞춰 CLAUDE.md·README·docs/api-contract.md·build.gradle.kts·코드 주석·테스트 주석에 남아있던 옛 이름 표기를 새 이름으로 정리
- README 의 관련 repo 링크(https://github.com/depromeet/PIKI-Server)도 이관된 좌표(https://github.com/TeamPiKi/core)로 갱신
- telemetry 값이 있는 application.yml(main·test)은 다른 세션이 rename 작업 중인 핫존이라 스킵
- 이 repo 를 가리키는 단독 'Extractor' 표기(PIKI 접두 없음)는 이번 정리 대상이 아니라 그대로 둠
- 기능 변경 없음, 산문만 수정
@m-a-king m-a-king self-assigned this Jul 11, 2026
@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 09a48eaa-cd3b-4f5a-9133-ffcfe3fd6abe

📥 Commits

Reviewing files that changed from the base of the PR and between 5a08bd4 and b956d8a.

📒 Files selected for processing (27)
  • .github/workflows/ci.yml
  • CLAUDE.md
  • README.md
  • build.gradle.kts
  • docs/api-contract.md
  • src/main/java/com/depromeet/piki/extractor/api/ExtractionController.java
  • src/main/java/com/depromeet/piki/extractor/api/ExtractionResponse.java
  • src/main/java/com/depromeet/piki/extractor/common/exception/ExtractionErrorCode.java
  • src/main/java/com/depromeet/piki/extractor/common/storage/ImageStorage.java
  • src/main/java/com/depromeet/piki/extractor/common/storage/ImageStorageException.java
  • src/main/java/com/depromeet/piki/extractor/common/storage/S3ImageStorage.java
  • src/main/java/com/depromeet/piki/extractor/domain/ProductLink.java
  • src/main/java/com/depromeet/piki/extractor/domain/ProductSnapshot.java
  • src/main/java/com/depromeet/piki/extractor/extraction/FallbackProductLinkExtractor.java
  • src/main/java/com/depromeet/piki/extractor/extraction/HeadlessExtractionProperties.java
  • src/main/java/com/depromeet/piki/extractor/extraction/HeadlessProductLinkExtractor.java
  • src/main/java/com/depromeet/piki/extractor/extraction/ProductLinkExtractor.java
  • src/main/java/com/depromeet/piki/extractor/extraction/gemini/GeminiProperties.java
  • src/main/java/com/depromeet/piki/extractor/extraction/headless/HeadlessRenderer.java
  • src/main/java/com/depromeet/piki/extractor/extraction/headless/HttpHeadlessRenderer.java
  • src/main/java/com/depromeet/piki/extractor/image/ImageExtractionService.java
  • src/main/java/com/depromeet/piki/extractor/image/domain/ProductImageException.java
  • src/test/java/com/depromeet/piki/extractor/api/ExtractionImageIntegrationTest.java
  • src/test/java/com/depromeet/piki/extractor/api/ExtractionLinkIntegrationTest.java
  • src/test/java/com/depromeet/piki/extractor/domain/ProductLinkTest.java
  • src/test/java/com/depromeet/piki/extractor/extraction/FallbackProductLinkExtractorTest.java
  • src/test/java/com/depromeet/piki/extractor/support/TestConventionTest.java

📝 Walkthrough

Walkthrough

The change updates project documentation, API contract terminology, build and CI comments, source comments, and test comments from legacy service names to core, extractor, and renderer. No executable code, configuration behavior, APIs, tests, or dependency declarations changed.

Changes

Service terminology alignment

Layer / File(s) Summary
Canonical service and API terminology
CLAUDE.md, README.md, docs/api-contract.md, build.gradle.kts, .github/workflows/ci.yml
Project conventions, service documentation, API contracts, build comments, and CI comments now use the updated core, extractor, and renderer terminology.
Runtime ownership and boundary comments
src/main/java/com/depromeet/piki/extractor/**
Source comments now describe caller ownership, storage responsibilities, extraction policies, renderer boundaries, configuration, and state transitions using the updated service names.
Test convention and contract references
src/test/java/com/depromeet/piki/extractor/**
Test comments and convention references use the updated caller and project terminology without changing test logic or assertions.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 20.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the PR’s main change: renaming old service references to core and renderer across docs and comments.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/prose-service-names

Comment @coderabbitai help to get the list of available commands.

@m-a-king m-a-king merged commit 209894a into main Jul 11, 2026
2 checks passed
@m-a-king m-a-king deleted the chore/prose-service-names branch July 11, 2026 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant