Conversation
For some reasons when I pick the precompiled Linux version everything works as expected. But building from source result in an Avalonia crash: > System.ArgumentException: 0 is not a valid value for 'FontSize'. > at Avalonia.PropertyStore.ValueStore.SetValue[T](StyledProperty`1 property, T value, BindingPriority priority) Don’t really know why. Could have built this application with a different Avalonia version? I don’t really use C# usually.
fix: fixed auto-detect of data folder to be based on textbox instead of saved value
feat: auto-detect of native dolphin
fix: crash on Mii Editor: Font Size 0
fix(gamebanana): Filter out mod results with content ratings
feat(flatpak): Provide Wheel Wizard URL handler `.desktop`
…tings-ux fix: Improve installation and settings UX
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (34)
📝 WalkthroughWalkthroughThis PR reworks Linux Flatpak Dolphin install/detection to use user-scoped Flatpak commands, adds native Dolphin detection, updates GameBanana models with content-rating/archived-file fields and API version, reformats language YAML files to block scalars with key renames, fixes a UI arrow icon, simplifies "Made by" text rendering, and bumps the release version. ChangesLinux Dolphin Flatpak Detection & Installation
GameBanana Content Ratings & Archived Files
Localization Reformatting
UI & Release Metadata
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant Settings as WhWzSettings
participant Installer as LinuxDolphinInstaller
participant Process as LinuxProcessService
Settings->>Installer: InstallFlatpakDolphin()
Installer->>Process: Run("flatpak remote-add --user ...")
Installer->>Process: Run("flatpak install --user -y ...")
Process-->>Installer: OperationResult<int>
Installer->>Installer: LaunchAndStopAsync()
Installer-->>Settings: OperationResult
Possibly related PRs
Suggested reviewers: Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
C:\Users\patchzy\.dotnet\dotnet.exe restore WheelWizard.slnC:\Users\patchzy\.dotnet\dotnet.exe test WheelWizard.sln --configuration Release --verbosity normalpassed: 174 tests, 0 failures.Summary by CodeRabbit
New Features
Bug Fixes