feat: refactor of installation locators and rough setup popup implementation#300
feat: refactor of installation locators and rough setup popup implementation#300altpyrion wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Some things I'm going to comment on up-front: I'm not sure if we can do something similar for Windows users, as the folder of the Dolphin installation with the For macOS, there are two locations we should indicate here, as seen in: .If Wheel Wizard is running sandboxed as a Flatpak, the file picker for the Dolphin location must not be displayed or enabled, by the way -- see my recent PR for this (#296). Lastly, if the file picker doesn't work with this kind of initial window, the last resort for me would be to just drop it and keep it in the regular settings window as-is, and only give the common options of Flatpak Dolphin, native Dolphin (Linux) as well as system-/user-wide |
|
Other than that, this looks really nice already, thanks! |
|
One more thing: What about the automatic installation of dolphin and flatpak? Should it still be a feature? Only shown if no flatpak install is found? On a separate screen or the screen I sent a screenshot of |
Yes, it would be good to keep this. Not sure if it would also lead to issues since it needs a pop-up as well for the progress window, though. |
|
If possible, a button next to where it says that the Dolphin Flatpak is not installed would be good to install the Flatpak. |
Purpose of this PR:
To start talk about a new and improved setup screen at first launch
How to Test:
Delete valid paths from config and the popup will start on next launch
What Has Been Changed:
Added first screen to select and detect Dolphin installations. Only implemented for Linux

Related Issue Link:
#291
Other
I am currently facing two design decisions i would like to discuss before implementing:
FilePickerHelper.OpenSingleFileAsyncdoesnt appear to work with popups. I am guessing that this is because ofvar topLevel = TopLevel.GetTopLevel(storageProvider.MainWindow);because at the beginning there is no MainWindow. I am not exactly sure how one could solve this. Maybe passing the context window by a new argument?