Skip to content

feat: refactor of installation locators and rough setup popup implementation#300

Draft
altpyrion wants to merge 1 commit into
TeamWheelWizard:devfrom
altpyrion:setup-rework
Draft

feat: refactor of installation locators and rough setup popup implementation#300
altpyrion wants to merge 1 commit into
TeamWheelWizard:devfrom
altpyrion:setup-rework

Conversation

@altpyrion

Copy link
Copy Markdown
Contributor

Purpose of this PR:

To start talk about a new and improved setup screen at first launch

How to Test:

Delete valid paths from config and the popup will start on next launch

What Has Been Changed:

Added first screen to select and detect Dolphin installations. Only implemented for Linux
image

Related Issue Link:

#291

Other

I am currently facing two design decisions i would like to discuss before implementing:

  1. FilePickerHelper.OpenSingleFileAsync doesnt appear to work with popups. I am guessing that this is because of var topLevel = TopLevel.GetTopLevel(storageProvider.MainWindow); because at the beginning there is no MainWindow. I am not exactly sure how one could solve this. Maybe passing the context window by a new argument?
  2. To check for installation on Mac and Windows, we would probably also need the same EnvironmentHelpers and simplifications for Windows and Mac as we have with Linux. Whats your opinion on how to best implement this?

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ef52e778-347d-443c-a890-5a71978490dd

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@altpyrion altpyrion marked this pull request as draft July 11, 2026 14:51
@matellush

matellush commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Some things I'm going to comment on up-front: I'm not sure if we can do something similar for Windows users, as the folder of the Dolphin installation with the Dolphin.exe will vary, but some of them might just have it on their Desktop. I'm honestly not sure if this would even make sense for Windows, unless we scan a large portion of the filesystem... It would of course be nice to have to get a list of potential Dolphin .exe files. For the auto-configuration of the Dolphin user folders, the method handling this for the browse folder in the settings should already provide good auto-detection which could be used for the initial setup wizard.

For macOS, there are two locations we should indicate here, as seen in:

public static string? TryToFindApplicationPath()
.

If Wheel Wizard is running sandboxed as a Flatpak, the file picker for the Dolphin location must not be displayed or enabled, by the way -- see my recent PR for this (#296).

Lastly, if the file picker doesn't work with this kind of initial window, the last resort for me would be to just drop it and keep it in the regular settings window as-is, and only give the common options of Flatpak Dolphin, native Dolphin (Linux) as well as system-/user-wide Dolphin.apps on macOS to choose from. Any other configurations shall then be made from within the normal settings.

@matellush

Copy link
Copy Markdown
Collaborator

Other than that, this looks really nice already, thanks!

@altpyrion

altpyrion commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

One more thing: What about the automatic installation of dolphin and flatpak? Should it still be a feature? Only shown if no flatpak install is found? On a separate screen or the screen I sent a screenshot of

@matellush

Copy link
Copy Markdown
Collaborator

One more thing: What about the automatic installation of dolphin and flatpak? Should it still be a feature? Only shown if no flatpak install is found? On a separate screen or the screen I sent a screenshot of

Yes, it would be good to keep this. Not sure if it would also lead to issues since it needs a pop-up as well for the progress window, though.

@matellush

Copy link
Copy Markdown
Collaborator

If possible, a button next to where it says that the Dolphin Flatpak is not installed would be good to install the Flatpak.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants