Add support for enums w/o needing to manually specify variations #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 12270279849Details
💛 - Coveralls |
rafaeljusto
approved these changes
Dec 11, 2024
Contributor
rafaeljusto
left a comment
rafaeljusto
left a comment
There was a problem hiding this comment.
Nice work with this feature request 👏
Contributor
Author
|
Despite the tests passing, this isn't working. My assumption is it's because we don't have any tests covering field types defined in another package/file. Investigating. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89
It will only attempt to figure out the variations if type:"enum" is specified and len(enums) is 0.
i.e. if someone uses the {enum} comment, or, for some reason, {enum: }.
The only edge cases I can think of here are in our own code, where we sometimes might not want "all" or "" exposed as enum options in the API even though they technically exist. In which case we'd still need to manually specify all the fields like we were doing prior to now.