Open
Conversation
- Add war.query.js, war.mapper.js, war.job.js - Add medicine.query.js, medicine.mapper.js, medicine.job.js - Add shared _mapperUtils.js (extractQid, buildEventDoc) - Add shared _runImport.js (runImport, startFromCLI) - Fix event query overlap logic in layers.service.js - War import verified: 1333 events upserted to MongoDB - Medicine import pending: query needs debugging
- Add TimelinePage with horizontal timeline visualization - Add EventDot, TimelineRow, EventPanel, YearAxis, LayerSelector components - Add CSS modules for all timeline components - Add AppLayout with navbar - Add React Router, React Query, Zustand wiring - Fix API URL and response parsing
- Separate Wikidata queries per medicine subcategory - Remove label-based category guessing - Assign fixed category per import task - Improve data clarity and pedagogical structure
- move shared SPARQL helpers to queries/_shared.js - fix war.job per-category error handling - remove invalid medicine task placeholder - add dotenv loading for CLI import jobs - verify war + medicine imports with dry-run
…ine label contrast
…aths after removing mapper files.
HIPPIEKICK
approved these changes
Mar 24, 2026
Contributor
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Nice job with this project Sara! I'm impressed with how it all came together. Your project is structured and overall clean (there's some unused/unfinished code, and some inconsistencies). However, you've met most of the requirements and you have some really nice functionality going on here. The only requirement I can see that's not met is 100% Lighthouse score (Touch targets do not have sufficient size or spacing) - so that could be something to think about. But I'll approve this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://historytimelines.netlify.app/