Skip to content

Fix: compound variants don't work when each variant is determined by media#42

Open
tkow wants to merge 5 commits into
Temzasse:mainfrom
MOCHI-inc-JAPAN:fix/41
Open

Fix: compound variants don't work when each variant is determined by media#42
tkow wants to merge 5 commits into
Temzasse:mainfrom
MOCHI-inc-JAPAN:fix/41

Conversation

@tkow
Copy link
Copy Markdown
Contributor

@tkow tkow commented Nov 16, 2022

Fix #39, #41

スクリーンショット 2022-11-16 16 37 47

@tkow tkow changed the title Fix Issue 41: compound variants don't work Fix: compound variants don't work when each variant is determined by media Nov 16, 2022
@tkow
Copy link
Copy Markdown
Contributor Author

tkow commented Nov 30, 2022

@Temzasse
Could you have time to check this PR?
This implements,

  1. Styles merge functionality ordered by these lines.
  2. Media styles extract finally matched value and explicitly process in same manner.
  3. Make latter conflict multiple match variants and styles prioritized.
  4. Fix compound variants works when they matches default values and media select variants.
<Component color={'@bp': { purple: true } underline={true} />

or

css({
  defaultVarinats: {
    color: 'purple'
  }
})
<Component underline={true} />

don't match purple==true && underline == true before.
5. Fix boolean flag media (#39)

@Temzasse
Copy link
Copy Markdown
Owner

Temzasse commented Dec 7, 2022

@tkow sorry for taking so long to review this. Would you mind rebasing this with the latest main? I will try to take a look at this during this week 🙂

@tkow
Copy link
Copy Markdown
Contributor Author

tkow commented Dec 9, 2022

@Temzasse Don't worry, I don't care when it's done. Have a good and relax vacation! I have no doubt and wonder most people in the world drives enthusiastic by World Cup makes me no choice to work.
I rebased from current latest branch and please check, If you feel like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix boolean flag based media style handling

2 participants