Fix: compound variants don't work when each variant is determined by media#42
Open
tkow wants to merge 5 commits into
Open
Fix: compound variants don't work when each variant is determined by media#42tkow wants to merge 5 commits into
tkow wants to merge 5 commits into
Conversation
This was referenced Nov 16, 2022
Contributor
Author
|
@Temzasse
<Component color={'@bp': { purple: true } underline={true} />or css({
defaultVarinats: {
color: 'purple'
}
})
<Component underline={true} />don't match |
Owner
|
@tkow sorry for taking so long to review this. Would you mind rebasing this with the latest main? I will try to take a look at this during this week 🙂 |
Contributor
Author
|
@Temzasse Don't worry, I don't care when it's done. Have a good and relax vacation! I have no doubt and wonder most people in the world drives enthusiastic by World Cup makes me no choice to work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #39, #41