Fix JNI crash when jBytes is null in SafeConvertToStdString#3254
Merged
Fix JNI crash when jBytes is null in SafeConvertToStdString#3254
Conversation
Add null check and exception handling for jBytes before calling GetArrayLength to prevent crash when String.getBytes() returns null due to OOM or other JNI exceptions. Fixes: #3045
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3254 +/- ##
=======================================
Coverage 77.10% 77.11%
=======================================
Files 415 415
Lines 22040 22040
Branches 6307 6307
=======================================
+ Hits 16995 16997 +2
+ Misses 3818 3817 -1
+ Partials 1227 1226 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
domchen
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When calling
SafeConvertToStdString, ifString.getBytes()returns null (due to OOM or other JNI exceptions), the subsequentGetArrayLength(jBytes)call will crash with:Related issue: #3045
Solution
Add null check and exception handling for
jBytesbefore callingGetArrayLength:Changes
jBytesafterCallObjectMethodExceptionCheck()to detect pending JNI exceptionsExceptionClear()to clear any pending exception before returning