fix: 子画布测试问题修复 --story=135418928 - #839
Merged
Mianhuatang8 merged 2 commits intoJul 29, 2026
Merged
Conversation
# Reviewed, transaction id: 83635
There was a problem hiding this comment.
Code Review 总结
本次 PR 修复了子画布(SubCanvas)相关的若干问题,主要包含三处变更:
- ProcessCanvas - 将节点删除时的连线处理逻辑提前到
removeNode之前执行,避免删除节点后无法获取关联边的问题。逻辑清晰,与循环容器分支保持一致。 - validatePipeline - 新增
SubCanvas类型节点的计数,修复了仅含子画布节点时误报"请添加任务节点"的校验问题。 - TemplateEdit - 将
checkNodeAndSaveTemplate改为 throw 异常 + async/await 模式,使校验失败时能正确中断保存流程。
整体改动合理,修复目标明确。有 2 处小问题供参考。
# Reviewed, transaction id: 83637
There was a problem hiding this comment.
Code Review 总结(增量审查)
上一轮审查提出的 2 个问题均已在最新提交 (80d58fb) 中修复:
- ✅ 格式问题:
subflow +subcanvas缺少空格 → 已修正为subflow + subcanvas - ✅ 逻辑问题:
onMultipleTabConfirm中multipleTabDialogShow = false位置不当 → 已移入 try 块内,校验失败时弹窗保持打开
新增代码无 Critical 或 Important 级别问题。整体改动质量良好,可以合入。
Mianhuatang8
merged commit Jul 29, 2026
dc94a5f
into
TencentBlueKing:develop_subcanvas
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed, transaction id: 83635