Skip to content

fix: 子画布测试问题修复 --story=135418928 - #839

Merged
Mianhuatang8 merged 2 commits into
TencentBlueKing:develop_subcanvasfrom
Mianhuatang8:subcanvs_vertify_save_node_error_state
Jul 29, 2026
Merged

fix: 子画布测试问题修复 --story=135418928#839
Mianhuatang8 merged 2 commits into
TencentBlueKing:develop_subcanvasfrom
Mianhuatang8:subcanvs_vertify_save_node_error_state

Conversation

@Mianhuatang8

Copy link
Copy Markdown
Collaborator

Reviewed, transaction id: 83635

# Reviewed, transaction id: 83635

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review 总结

本次 PR 修复了子画布(SubCanvas)相关的若干问题,主要包含三处变更:

  1. ProcessCanvas - 将节点删除时的连线处理逻辑提前到 removeNode 之前执行,避免删除节点后无法获取关联边的问题。逻辑清晰,与循环容器分支保持一致。
  2. validatePipeline - 新增 SubCanvas 类型节点的计数,修复了仅含子画布节点时误报"请添加任务节点"的校验问题。
  3. TemplateEdit - 将 checkNodeAndSaveTemplate 改为 throw 异常 + async/await 模式,使校验失败时能正确中断保存流程。

整体改动合理,修复目标明确。有 2 处小问题供参考。

Comment thread frontend/src/utils/validatePipeline.js Outdated
Comment thread frontend/src/views/template/TemplateEdit/index.vue Outdated
# Reviewed, transaction id: 83637

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review 总结(增量审查)

上一轮审查提出的 2 个问题均已在最新提交 (80d58fb) 中修复:

  1. 格式问题subflow +subcanvas 缺少空格 → 已修正为 subflow + subcanvas
  2. 逻辑问题onMultipleTabConfirmmultipleTabDialogShow = false 位置不当 → 已移入 try 块内,校验失败时弹窗保持打开

新增代码无 Critical 或 Important 级别问题。整体改动质量良好,可以合入。

@Mianhuatang8
Mianhuatang8 merged commit dc94a5f into TencentBlueKing:develop_subcanvas Jul 29, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants