feat: 增加循环子画布节点 --story=135418928 - #847
Merged
luofann merged 40 commits intoAug 3, 2026
Merged
Conversation
# Reviewed, transaction id: 82268
# Reviewed, transaction id: 82269
# Reviewed, transaction id: 82306
# Reviewed, transaction id: 82515
# Reviewed, transaction id: 82543
# Reviewed, transaction id: 82627
# Reviewed, transaction id: 82633
# Reviewed, transaction id: 82733
# Reviewed, transaction id: 82738
# Reviewed, transaction id: 82833
# Reviewed, transaction id: 83007
# Reviewed, transaction id: 83008
# Reviewed, transaction id: 83099
# Reviewed, transaction id: 83100
# Reviewed, transaction id: 83145
# Reviewed, transaction id: 83213
# Reviewed, transaction id: 83215
# Reviewed, transaction id: 83230
# Reviewed, transaction id: 83231
# Reviewed, transaction id: 83282
# Reviewed, transaction id: 83324
# Reviewed, transaction id: 83341
# Reviewed, transaction id: 83382
# Reviewed, transaction id: 83387
# Reviewed, transaction id: 83409
# Reviewed, transaction id: 83410
# Reviewed, transaction id: 83427
# Reviewed, transaction id: 83428
# Reviewed, transaction id: 83430
# Reviewed, transaction id: 83512
# Reviewed, transaction id: 83518
# Reviewed, transaction id: 83635
# Reviewed, transaction id: 83637
# Reviewed, transaction id: 83678
# Reviewed, transaction id: 83691
# Reviewed, transaction id: 83758
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #847 +/- ##
=======================================
Coverage 83.10% 83.10%
=======================================
Files 307 307
Lines 18167 18167
=======================================
Hits 15098 15098
Misses 3069 3069 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔍 Code Review Summary
概述
本 PR 实现了前端画布的循环节点（SubCanvas / Loop Group Node）功能，涉及大量画布交互逻辑、节点嵌入/管理、复制粘贴时的 ID 重映射、校验规则扩展等。整体设计合理，功能完整度高。以下是一些需要关注的问题。
发现的问题
| # | 严重度 | 文件 | 问题 |
|---|---|---|---|
| 1 | 🔴 Critical | validatePipeline.js:572 | 残留的无效表达式语句（dead code） |
| 2 | 🔴 Critical | validatePipeline.js:294 | SubCanvas NODE_RULE.allowed_out 包含不可达类型 'start' |
| 3 | 🟡 Important | 多文件 | 魔法数字 415/158 在 5+ 文件中重复，应提取为共享常量 |
| 4 | 🟡 Important | shortcutPanel.vue / index.vue | innerToOuterTypeMap 在两处完全重复定义 |
| 5 | 🟡 Important | index.vue:2188-2192 | forEach 回调体缩进错误（1 空格） |
| 6 | 🟡 Important | loop.vue:292-303 | resize 溢出检测的坐标参考系可能不一致 |
Automated review by CI bot
# Reviewed, transaction id: 83772
There was a problem hiding this comment.
🔍 Code Review Summary (Incremental)
之前报告的问题状态
| # | 状态 | 说明 |
|---|---|---|
| 1 | ✅ 已解决 | validatePipeline.js 中的无效表达式语句已删除 |
| 2 | ✅ 已解决 | SubCanvas allowed_out 中的不可达类型 'start' 已移除 |
| 3 | 魔法数字 415/158 仍分散在 6+ 文件中 | |
| 4 | innerToOuterTypeMap 仍在两处重复定义 |
|
| 5 | 需复核 | 缩进问题（请确认是否已修正） |
| 6 | resize 坐标参考系不一致（实际影响较小） |
新发现的问题
本次增量提交中未发现新的 Critical 级别问题。整体代码质量良好，循环子画布的嵌套 pipelineTree 管理、embedding 逻辑、校验规则扩展等实现完整。
Automated incremental review
luofann
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.