Skip to content

fix: 避免引擎日志重复写入 - #849

Merged
dengyh merged 1 commit into
TencentBlueKing:developfrom
dengyh:ai/fix-duplicate-engine-logs-develop
Aug 3, 2026
Merged

fix: 避免引擎日志重复写入#849
dengyh merged 1 commit into
TencentBlueKing:developfrom
dengyh:ai/fix-duplicate-engine-logs-develop

Conversation

@dengyh

@dengyh dengyh commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

问题原因

bamboo_enginepipeline_enginepipeline 在自身绑定 root Handler 后仍向父 logger 传播,导致同一个 Handler 沿 logger 继承链被重复调用。PaaS3 日志模式下,pipeline.eri.log 的数据库 Handler 被移除后又补上 root Handler,最多会将同一条日志写入三次。

修改内容

  • bamboo_enginepipeline_enginepipeline 设为对应日志链路的传播终点。
  • PaaS3 模式下允许 pipeline.eri.log 使用空 Handler 并传播到 pipeline,避免重复绑定 root
  • 增加 DATABASE/PaaS3 两种模式的日志路由回归测试。
  • 确认数据库节点日志 Handler 在 DATABASE 模式下仍调用一次,在 PaaS3 模式下仍按原逻辑关闭。

影响范围

仅调整 Python logging Handler 的传播路径,不修改日志内容、级别、格式、Trace 信息、节点信息或日志查询接口。合法的重复业务日志不会被过滤。

该修复与 master PR #848 内容一致,本 PR 基于最新 develop 单独创建,避免引入 master/develop 间的其他提交差异。

验证

  • pytest tests/project_settings tests/engine/task/test_node_log.py -q --no-cov:25 passed。
  • pre-commit run --files config/default.py tests/project_settings/test_logging_settings.py:全部通过。

@dengyh
dengyh merged commit 59ca2db into TencentBlueKing:develop Aug 3, 2026
8 checks passed

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

✨ 整体改动清晰合理。通过将 pipelinebamboo_enginepipeline_enginepropagate 设为 False,解决了日志重复写入 root handler 的问题(这些 logger 已显式包含 root handler,无需再通过 propagation 再写一次)。

移除 empty-handlers fallback 也是安全的:pipeline.eri.log 在非 DATABASE 模式下 handlers 被清空后,仍通过 propagate: True 向父级 pipeline logger 传递,最终到达 root handler。

测试覆盖充分,验证了核心场景(每条日志只写一次 root handler、DATABASE 模式保留 context handler、PaaS3 模式移除 context handler)。

无 Critical 或 Important 级别问题。

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.62%. Comparing base (4da513d) to head (71e88d5).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #849      +/-   ##
===========================================
+ Coverage    83.60%   83.62%   +0.02%     
===========================================
  Files          324      324              
  Lines        20722    20724       +2     
===========================================
+ Hits         17324    17330       +6     
+ Misses        3398     3394       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants