Use cleaner urls (slugify) #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added migration to modify existing data to a 3-padded field Charfield (ex. #1) * Modified the comicimporter.py to add the issue number as a 3-padded String. * Added the comicarchive api to use it's IssueString function.
* Modified the Publisher model to addd a slug field * Added a migration to get the slug from the Publisher name * Update url to use the slug instead of the publisher db id. * Update the comicimport to save the slug on new & updated publishers.
* Modified the Series model to addd a slug field
* Added a migration to get the slug from the Series name and year (if available)
* Update url to use the slug instead of the series db id.
* Update the comicimport to save the slug on new & updated series.
* Modified the Creators model to addd a slug field. * Added a migration to get the slug from the Creator's name. * Update url to use the slug instead of the creators db id. * Update the comicimport to save the slug on new & updated creatrors.
* Modified the Teams model to addd a slug field. * Added a migration to get the slug from the Teams name. * Update url to use the slug instead of the teams db id. * Update the comicimport to save the slug on new & updated teams.
* Modified the Character model to addd a slug field. * Added a migration to get the slug from the Character name. * Update url to use the slug instead of the character db id. * Update the comicimport to save the slug on new & updated characters.
* Modified the Arc model to addd a slug field. * Added a migration to get the slug from the Arc name. * Update url to use the slug instead of the arc db id. * Update the comicimport to save the slug on new & updated arcs.
* Modified the Issue model to addd a slug field. * Added a migration to get the slug from the Issue name. * Update url to use the slug instead of the issue db id. * Update the comicimport to save the slug on new & updated issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a branch that uses more human readable urls. For example: using '/publisher/dc-comics', instead of 'publisher/1'
I branched this off the issue-number branch (#53), to make debasing easier due to migrations sequence. Any questions, just holler.