Adding support for fancy pointers and scoped_allocator_adaptors#17
Open
LukasKerk wants to merge 6 commits intoTessil:masterfrom
Open
Adding support for fancy pointers and scoped_allocator_adaptors#17LukasKerk wants to merge 6 commits intoTessil:masterfrom
LukasKerk wants to merge 6 commits intoTessil:masterfrom
Conversation
* Started to add fancy pointer support to the sparse array class and a lot of tests to ensure that nothing is broken. * Fixxed a bug in the move construction test. * Started to work on sparse_hash * Some more changes for the iterators. * Ported the set tests to work with maps. I could have generalized the tests even more to reduce code duplication, however the tests are already complicated enough. * Integrated boost::to_address directly into the code. * A bit of tidy up. Now the fancy pointer tests are integrated into the "normal" test suit and can be compiled with C++-11. * added test for value() with fancy pointer * added missing const * Fixxed a bug in the OffsetAllocator, also did some work on erase. * added Remove_Const struct for overloading const_cast with @LukasKerk * Added the "const_cast" for boost offset pointers in its own header. * Fixed a typo in a test output. * Corrected comments. Co-authored-by: Alexander Bigerl <alexander@bigerl.eu>
* Initial commit. First few tests, found one problem. * Now scoped allocators can be used. However emplace still does not work as it should. * Some cleanup. * Formatting and removing comments.
LukasKerk
changed the title
BOOST_TEST_REQUIRE seems to be a pretty recent addition to the boost unittest framework. It is now replaced by BOOST_REQUIRE
Owner
|
Thank you very much for your contribution. I have to dig more into it but I'm a bit wary of the size of the change and maintenance burden for something that is interesting but quite niche. Would it be eventually be possible to just adapt |
* reverted whitespace changes * added typename for sparse_hash::value_type/const_pointer
Author
|
Sorry for the many commits. A few of the CI problems were a bit tricky to find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for scoped_allocator_adaptor and allocators with fancy pointers like boost offset pointers.
With these additions, it is now possible to persist the sparse_set and sparse_map via boost's interprocess. When using a stable hash function, an allocator that operates on memory mapped files can be used to store a populated sparse-hash map or set between program executions.
The scoped_allocator_adaptor is needed for nested containers. Take a set of sets of integers as an example. Before it wasn't possible to give the inner sets their own custom allocator or to give a single allocator to all sets.