fix const value return by emplace iterator#24
Open
firedtoad wants to merge 3 commits intoTessil:masterfrom
Open
fix const value return by emplace iterator#24firedtoad wants to merge 3 commits intoTessil:masterfrom
firedtoad wants to merge 3 commits intoTessil:masterfrom
Conversation
with const this code will not compile tsl::sparse_map<uint32_t,uint32_t> spp; const auto it=spp.emplace(1,1); it.first->second=1;
Owner
|
Thank you for the contribution, unfortunately casting a |
Author
|
It is not undefined behaviour, because they have the same memory layout.
I use this modified version in my project. And it passed the clang && gcc
UBsan!
Thibaut Goetghebuer-Planchon ***@***.***> 于2023年10月10日周二
03:25写道:
… Casting a std::pair<K, V>& to a std::pair<const K, V>& is an undefined
behaviour. See
https://stackoverflow.com/questions/8305793/is-it-possible-to-cast-a-pairkey-value-to-a-pairconst-key-value
for more information.
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK6QJWABV22VUVRPYKJM2LX6RFSHAVCNFSM6AAAAAAYKU2DOGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJTGU3TCMBWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
The new standard shows that it is layout compatible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with const this code will not compile
tsl::sparse_map<uint32_t,uint32_t> spp;
const auto it=spp.emplace(1,1);
it.first->second=1;