Ensure trailing slashes in session.mount() URLs#93
Merged
BenjamenMeyer merged 2 commits intoTestInABox:masterfrom Apr 26, 2025
Merged
Ensure trailing slashes in session.mount() URLs#93BenjamenMeyer merged 2 commits intoTestInABox:masterfrom
BenjamenMeyer merged 2 commits intoTestInABox:masterfrom
Conversation
BenjamenMeyer
approved these changes
Apr 26, 2025
Member
|
@allrob23 cool - I'll merge once all the checks are passing. Reviewing the build failure it seems that Excerpt from the logs: |
Contributor
Author
|
Hi @BenjamenMeyer, I made a commmit, let me know if this is what you expected. |
BenjamenMeyer
approved these changes
Apr 26, 2025
Member
Thanks that should work |
Member
|
@allrob23 awesome - thanks for the contribution. |
Member
|
@allrob23 released 0.14.0 with your changes. Thank! |
Contributor
Author
|
@BenjamenMeyer thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While reviewing the documentation for Python Requests, I noticed this recommendation:
I know that the code work great and do their job, but ensuring trailing slashes would align them with the docs and make the URL prefixes more precise.
Changes
This ensures the URI always has a trailing slash, providing consistent behavior regardless of how the URI was originally provided.