Skip to content

Conversation

@Sujishark
Copy link
Contributor

@Sujishark Sujishark commented Nov 13, 2023

Found a new flaky test in amazon-pay-api-sdk-java/

com.amazon.pay.api.UtilTest.testEnhanceResponseWithShippingAddressList

Error Logs:

com.amazon.pay.api.UtilTest.testEnhanceResponseWithShippingAddressList -- Time elapsed: 0.002 s <<< FAILURE!
org.junit.ComparisonFailure: expected:<...pingAddressList":[{"[city":null,"addressId":"amzn1.address.ABC","phoneNumber":"8910111213","postalCode":"123-4567","stateOrRegion":"MNO","county":null,"addressLine3":null,"name":"DEF","district":null,"countryCode":"JP","addressLine2":"JKL","addressLine1":"GHI"]}]}> but was:<...pingAddressList":[{"[postalCode":"123-4567","county":null,"addressId":"amzn1.address.ABC","phoneNumber":"8910111213","countryCode":"JP","addressLine3":null,"addressLine1":"GHI","addressLine2":"JKL","name":"DEF","stateOrRegion":"MNO","city":null,"district":null]}]}>
	at org.junit.Assert.assertEquals(Assert.java:117)
	at org.junit.Assert.assertEquals(Assert.java:146)
	at com.amazon.pay.api.UtilTest.testEnhanceResponseWithShippingAddressList(UtilTest.java:257)

I've fixed this flaky test and raised a tentative PR as well.
Sujishark/amazon-pay-api-sdk-java#1

Once merged into IDoFT, I'll raise a real PR for the fix.

@darko-marinov
Copy link
Contributor

I'm still not sure about the difference between similar and equals, but feel free to open a real PR when confident and change the status to Opened.

@Sujishark
Copy link
Contributor Author

Opened real PR: amzn/amazon-pay-api-sdk-java#21

@darko-marinov darko-marinov merged commit de1f2c8 into TestingResearchIllinois:main Nov 14, 2023
wuh3 pushed a commit to wuh3/idoft that referenced this pull request Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants