Skip to content

Improve error message when directory path is passed instead of file #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srimajaya123-blip wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error message when directory path is passed instead of file #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/rich_cli/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from operator import itemgetter
import sys
from typing import TYPE_CHECKING, List, NoReturn, Optional, Tuple

import os
import click
from pygments.util import ClassNotFound
from rich.console import Console, RenderableType
Expand Down Expand Up @@ -98,6 +98,10 @@ def read_resource(path: str, lexer: Optional[str]) -> Tuple[str, Optional[str]]:
except Exception:
pass
return (text, lexer)


if path != "-" and os.path.isdir(path):
on_error(f"{escape(path)} is a directory, not a file")
try:
if path == "-":
return (sys.stdin.read(), None)
Expand Down