fix(ansi): handle CRLF line endings in AnsiDecoder.decode#4091
Open
armorbreak001 wants to merge 1 commit intoTextualize:masterfrom
Open
fix(ansi): handle CRLF line endings in AnsiDecoder.decode#4091armorbreak001 wants to merge 1 commit intoTextualize:masterfrom
armorbreak001 wants to merge 1 commit intoTextualize:masterfrom
Conversation
CRLF line endings left a bare \r after rstripping \n, which
decode_line then consumed via rsplit('\\r', 1)[-1], yielding
empty strings for every line.
Member
|
Your PR has been closed due to a AI policy violation. Please read the following before submitting further PRs. https://github.com/Textualize/textual/blob/main/AI_POLICY.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Text.from_ansi()receives a string with CRLF (\r\n) line endings, every line of content is lost — the result is all empty strings.Root cause:
AnsiDecoder.decode()splits on \n, strips trailing \n via.rstrip("\n"), then passes each line todecode_line(), which runs.rsplit("\r", 1)[-1]to handle terminal carriage-return overwrite semantics. When the input has CRLF endings, a bare \r remains after stripping;decode_lineinterprets that trailing \r as an overwrite and returns the (empty) portion after it.Fix: strip trailing \r alongside \n in
decode():.rstrip("\n\r").Reproduction:
Closes #4090