Skip to content

Fix Windows file links in RichHandler log output #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
souhil25 wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −3
Open

Fix Windows file links in RichHandler log output #4105

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions rich/_log_render.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from datetime import datetime
from typing import Iterable, List, Optional, TYPE_CHECKING, Union, Callable
from pathlib import Path


from .text import Text, TextType
Expand Down Expand Up @@ -71,15 +72,26 @@ def __call__(
row.append(Renderables(renderables))
if self.show_path and path:
path_text = Text()

uri = ""
if link_path:
try:
uri = Path(link_path).absolute().as_uri()
except ValueError:
uri = ""

path_text.append(
path, style=f"link file://{link_path}" if link_path else ""
path,
style=f"link {uri}" if uri else "",
)
if line_no:

if line_no is not None:
path_text.append(":")
path_text.append(
f"{line_no}",
style=f"link file://{link_path}#{line_no}" if link_path else "",
style=f"link {uri}#{line_no}" if uri else "",
)

row.append(path_text)

output.add_row(*row)
Expand Down