Fix plan view offsets for coordinated IFC models#264
Open
javi-codeworks wants to merge 1 commit into
Open
Conversation
Collaborator
|
We have officially released the new library components on September 20 2023. This library substitutes web-ifc-three and web-ifc-viewer. Both WIV and WIT will remain up, but they will be deprecated and won't be maintained any longer. You can find the new docs here. All our efforts are going towards components now. The API is very similar, so I strongly suggest you make the leap and start using it. If you still face this issue with it, you can open an issue there and we'll take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126.
Also helps #102 by centering plan-view camera moves on the selected model instead of assuming the model is at world origin.
Summary
ifcManager.state.coordinationMatrixfor plan/storey elevation offsets when a coordination matrix has been applied to loaded geometry.Verification
npm.cmd install --legacy-peer-deps --ignore-scriptsnpm.cmd run build --workspace viewerJest was attempted with
--runInBand --passWithNoTests, but the repo's Jest 27 setup cannot load its TypeScript ESMjest.config.tsunder the current npm workspace install. Noviewertest files were present.