Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

add unichain support - #193

Merged
Lomet merged 2 commits into
masterfrom
issue-192
Jul 9, 2025
Merged

add unichain support#193
Lomet merged 2 commits into
masterfrom
issue-192

Conversation

@YouStillAlive

Copy link
Copy Markdown
Member

closes #192

@YouStillAlive
YouStillAlive requested a review from Copilot July 9, 2025 10:34

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the Unichain network by defining its chain configuration and registering it alongside other chains.

  • Introduces a new UnichainConfig with network details and deployed contract addresses
  • Imports and registers UnichainConfig in the global AVAILABLE_CHAINS map

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/contracts/configs/Unichain.config.ts New chain config for Unichain (IDs, RPC, Explorer, contracts)
src/constants/index.ts Import and registration of UnichainConfig in AVAILABLE_CHAINS
Comments suppressed due to low confidence (3)

src/contracts/configs/Unichain.config.ts:16

  • [nitpick] The explorer name uses inconsistent capitalization. Consider renaming to "Unichain Pacific Explorer" to match the naming style of other chain configs.
        name: "unichain-pacific Explorer",

src/constants/index.ts:19

  • There’s no accompanying documentation or README update announcing Unichain support. Consider updating the project docs to list Unichain among the supported chains.
import { UnichainConfig } from "../contracts/configs/Unichain.config"

src/constants/index.ts:42

  • No tests have been added to verify that UnichainConfig is registered correctly. Consider adding a unit test to ensure it appears in AVAILABLE_CHAINS with the expected settings.
AVAILABLE_CHAINS.set(130, UnichainConfig)

@YouStillAlive
YouStillAlive requested a review from Lomet July 9, 2025 10:47
@Lomet
Lomet merged commit 33fa4ea into master Jul 9, 2025
6 checks passed
@Lomet
Lomet deleted the issue-192 branch July 9, 2025 11:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add Unichain to config

3 participants