Open
Conversation
cjdutoit
reviewed
Jan 27, 2025
|
|
||
| namespace ADotNet.Models.Pipelines.GithubPipelines.DotNets.Tasks | ||
| { | ||
| public class InstallPlaywrightTask : GithubTask |
Collaborator
There was a problem hiding this comment.
Not expecting this file. There is another open PR for this component. Can we remove this file from the PR so components can be reviewed individually
Contributor
Author
There was a problem hiding this comment.
Yeah, That's because this PR's branche is based on the other one @cjdutoit
cjdutoit
reviewed
Jan 27, 2025
| { | ||
| public class WorkloadUpdateTask : GithubTask | ||
| { | ||
| public override string Run { get; set; } = "dotnet workload update"; |
Collaborator
There was a problem hiding this comment.
Add descriptive documentation.
Collaborator
There was a problem hiding this comment.
@hassanhabib don't have an issue with this task itself, but but do we have some criteria on when to allow new tasks VS just using the generic task command in the job like below?
new GithubTask()
{
Name = "Update installed workloads",
Run = "dotnet workload update"
},
cjdutoit
reviewed
Jan 27, 2025
Co-authored-by: Christo du Toit <christo@dutoit.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #136