Skip to content

:octocat: Set NDG2 as default option#18

Merged
francisbarton merged 5 commits intomainfrom
francisbarton/issue16
Apr 13, 2026
Merged

:octocat: Set NDG2 as default option#18
francisbarton merged 5 commits intomainfrom
francisbarton/issue16

Conversation

@francisbarton
Copy link
Copy Markdown
Member

@francisbarton francisbarton commented Apr 10, 2026

Closes #16

This PR:

  • Moves NDG choice from the YAML config file to a function argument (ndg_variant). Passing in an ndg value to override the config default previously would have involved passing in an argument named non-demographic_adjustment via ..., which is an awkward argument to type due to the - requiring backticks, and is hard to remember
  • Bumps the package version to 0.5

@francisbarton francisbarton marked this pull request as ready for review April 13, 2026 08:23
@francisbarton francisbarton requested review from matt-dray and removed request for StatsRhian April 13, 2026 08:23
Copy link
Copy Markdown

@matt-dray matt-dray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, makes sense. Nice to simplify the if else logic as well.

@francisbarton francisbarton merged commit 758a4db into main Apr 13, 2026
@francisbarton francisbarton deleted the francisbarton/issue16 branch April 13, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ndg2 should be the default option (not ndg3)

2 participants