refactor: improve median calculator class design and readability - #6349
Merged
siriak merged 3 commits intoJul 7, 2025
Merged
Conversation
alxkm
requested review from
BamaCharanChhandogi,
DenizAltunkapan,
siriak,
vil02 and
yanglbme
as code owners
July 6, 2025 19:30
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6349 +/- ##
=========================================
Coverage 74.55% 74.56%
- Complexity 5452 5454 +2
=========================================
Files 682 682
Lines 19032 19033 +1
Branches 3689 3688 -1
=========================================
+ Hits 14190 14192 +2
Misses 4278 4278
+ Partials 564 563 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored the abstract class
MedianOfRunningArrayto improve clarity, extensibility, and maintainability.Changes made:
median()→getMedian()for clearer naming convention.balanceHeapsIfNeeded()to reduce code duplication.insert()andgetMedian()final to prevent override and preserve consistency.final.@throwstag when median is requested on an empty data set.clang-format -i --style=file path/to/your/file.java