Skip to content

Compression/ppma#14810

Open
Nert53 wants to merge 3 commits into
TheAlgorithms:masterfrom
Nert53:compression/ppm
Open

Compression/ppma#14810
Nert53 wants to merge 3 commits into
TheAlgorithms:masterfrom
Nert53:compression/ppm

Conversation

@Nert53

@Nert53 Nert53 commented Jun 17, 2026

Copy link
Copy Markdown

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing. -> Adding doctest to this is very chaotic, because outputs are very long even for short output.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels Jun 17, 2026

@algorithms-keeper algorithms-keeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread data_compression/ppma.py Outdated
Core class for PPM compression algorithm containing compression and decompression.
"""

def __init__(self, max_order: int = 2, alphabet_size: int = 256):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide return type hint for the function: __init__. If the function does not return a value, please provide the type hint as: def function() -> None:

Comment thread data_compression/ppma.py
defaultdict(lambda: defaultdict(int)) for _ in range(max_order + 1)
]

def encode_text(self, text: str) -> dict:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function encode_text

Comment thread data_compression/ppma.py

return {"readable_output": output, "ranges": output_ranges}

def decode_text(self, ranges: list) -> str:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function decode_text

Comment thread data_compression/ppma.py

return decoded_text

def _get_context_probs(self, order: int, context: str) -> tuple[dict, int]:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function _get_context_probs

Comment thread data_compression/ppma.py

return dict(counts), total_count

def process_char(self, char: str) -> tuple:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function process_char

Comment thread data_compression/ppma.py

return output, output_ranges

def _update_models(self, char: str) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function _update_models

Comment thread data_compression/ppma.py
(self.history + char)[-self.max_order :] if self.max_order > 0 else ""
)

def __reset_memory(self) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function __reset_memory

Comment thread data_compression/ppma.py
defaultdict(lambda: defaultdict(int)) for _ in range(self.max_order + 1)
]

def __str__(self) -> str:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function __str__

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label Jun 17, 2026
@algorithms-keeper algorithms-keeper Bot removed the require type hints https://docs.python.org/3/library/typing.html label Jun 17, 2026

@algorithms-keeper algorithms-keeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

Comment thread data_compression/ppma.py
defaultdict(lambda: defaultdict(int)) for _ in range(max_order + 1)
]

def encode_text(self, text: str) -> dict:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function encode_text

Comment thread data_compression/ppma.py

return {"readable_output": output, "ranges": output_ranges}

def decode_text(self, ranges: list) -> str:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function decode_text

Comment thread data_compression/ppma.py

return decoded_text

def _get_context_probs(self, order: int, context: str) -> tuple[dict, int]:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function _get_context_probs

Comment thread data_compression/ppma.py

return dict(counts), total_count

def process_char(self, char: str) -> tuple:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function process_char

Comment thread data_compression/ppma.py

return output, output_ranges

def _update_models(self, char: str) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function _update_models

Comment thread data_compression/ppma.py
(self.history + char)[-self.max_order :] if self.max_order > 0 else ""
)

def __reset_memory(self) -> None:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function __reset_memory

Comment thread data_compression/ppma.py
defaultdict(lambda: defaultdict(int)) for _ in range(self.max_order + 1)
]

def __str__(self) -> str:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file data_compression/ppma.py, please provide doctest for the function __str__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant