Open
Conversation
Upgrade the sustained hits button: When there are several dice colors and whatever the currently selected color, we clone the critical dice in order to add the correct dice color. Involves a slight change on how the sustained hits come in: they come on top of the previous dice.
Update diceTable.ttslua to generate color-sensitive-sustained hits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the "Sustained hits" button takes the number of critical hits and generates this many new dice with the currently selected new dice color.
So, when we have several dice colors, the added dice don't match the original dice.
To enhance this feature in this specific scenario, this PR's approach is to clone the critical dice when generating sustained hits, so that we keep the same color repartition.
This causes a slight change in how the sustained hits are added : they're now directly spawned above the previous dice.