Skip to content

Conversation

@RMarx1456
Copy link
Contributor

@RMarx1456 RMarx1456 commented Jan 5, 2026

Congrats on taking the first step to contributing to the Sample Programs repository maintained by [The Renegade Coder][renegade-coder]!
For simplicity, please make sure that your pull request includes one and only one contribution.

Please fill one of the sections below as applicable.
Please also add any other relevant information to the Notes section at the bottom.
You may delete or just ignore any other sections.
For more information please refer to our [contributing documentation][contributing]

I Am Adding a New Code Snippet in an Existing Language

  • I fixed Add Quine in x86 64 #5290
  • I did not include any extra folders/libraries
  • I named the pull request using Add {PROJECT} in {LANGUAGE} format

@github-actions github-actions bot added enhancement Any code that improves the repo quine See: https://sampleprograms.io/projects/quine/ labels Jan 5, 2026
@RMarx1456 RMarx1456 marked this pull request as ready for review January 5, 2026 19:57
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading your own file is not what this project is supposed to do. Instead, it is supposed to output a string to stdout that looks exactly like the source code of the program.

Also, please fill out the checkboxes in the PR using [x].

@RMarx1456
Copy link
Contributor Author

I see how it's supposed to work now. I will fix it.

@RMarx1456
Copy link
Contributor Author

I fixed the quine logic. Instead of reading its own ASM file from the directory, it prints out the program from a string inside the program. One of the tougher parts was maintaining alignment and string size as I had to make changes to get it to be the same.

@RMarx1456 RMarx1456 requested a review from rzuckerm January 6, 2026 07:44
Copy link
Collaborator

@rzuckerm rzuckerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @RMarx1456 . Thanks for your contribution.

@rzuckerm rzuckerm merged commit 08a2dd5 into TheRenegadeCoder:main Jan 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Any code that improves the repo quine See: https://sampleprograms.io/projects/quine/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Quine in x86 64

2 participants