Skip to content

feat(buffer): add some new function bindings. #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheSpyder merged 2 commits into from
Mar 15, 2025
Merged

feat(buffer): add some new function bindings. #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ac6926
feat(buffer): add some new function bindings.
muqiuhan Jan 19, 2025
e1f426f
chore: update rescript and deprecate Buffer.slice methods
muqiuhan Mar 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions lib/js/src/Cluster.bs.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"changie": "^1.18.0",
"onchange": "^7.1.0",
"pta": "^1.2.0",
"rescript": "^11.0.1",
"rescript": "^11.1.0",
"zora": "^5.2.0"
},
"files": [
Expand Down
0 bsconfig.json → rescript.json
View file
Open in desktop
File renamed without changes.
21 changes: 19 additions & 2 deletions src/Buffer.res
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,8 +272,25 @@ external readUintBE: (t, ~offset: int, ~length: int) => float = "readUintBE"
@send
external readUintLE: (t, ~offset: int, ~length: int) => float = "readUintLE"

@send external slice: (t, ~start: int, ~end_: int) => t = "slice"
@send external sliceToEnd: (t, ~start: int) => t = "slice"
@send
external readBigInt64BE: (t, ~offset: int) => bigint = "readBigInt64BE"
Copy link
Contributor Author

@muqiuhan muqiuhan Jan 19, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI says there are compilation errors here:

   We've found a bug for you!
  /home/runner/work/rescript-nodejs/rescript-nodejs/src/Buffer.res:276:47-52

  274 │ 
  275 │ @send
  276 │ external readBigInt64BE: (t, ~offset: int) => bigint = "readBigInt64BE
      │ "
  277 │ 
  278 │ @send

  This type constructor, `bigint`, can't be found.
  If you wanted to write a recursive type, don't forget the `rec` in `type rec`

But rescript 11.1 already treats bigint as primitive type: Primitive Types | Big Integer.

Maybe it's because the rescript version in the devDependencies of the current project is 11.0.1:

  "devDependencies": {
    "rescript": "^11.0.1",
  },

Copy link
Owner

@TheSpyder TheSpyder Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this repo is quite out of date, feel free to upgrade.


@send
external readBigInt64LE: (t, ~offset: int) => bigint = "readBigInt64LE"

@send
external readBigUint64BE: (t, ~offset: int) => bigint = "readBigUInt64BE"

@send
external readBigUint64LE: (t, ~offset: int) => bigint = "readBigUInt64LE"

@deprecated("Use `subarray` instead") @send
external slice: (t, ~start: int, ~end_: int) => t = "slice"
@deprecated("Use `subarrayToEnd` instead") @send
external sliceToEnd: (t, ~start: int) => t = "slice"

@send external subarray: (t, ~start: int, ~end_: int) => t = "subarray"
@send external subarrayToEnd: (t, ~start: int) => t = "subarray"

@send external swap16: t => t = "swap16"
@send external swap32: t => t = "swap32"
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -971,19 +971,19 @@ __metadata:
changie: "npm:^1.18.0"
onchange: "npm:^7.1.0"
pta: "npm:^1.2.0"
rescript: "npm:^11.0.1"
rescript: "npm:^11.1.0"
zora: "npm:^5.2.0"
languageName: unknown
linkType: soft

"rescript@npm:^11.0.1":
version: 11.0.1
resolution: "rescript@npm:11.0.1"
"rescript@npm:^11.1.0":
version: 11.1.4
resolution: "rescript@npm:11.1.4"
bin:
bsc: bsc
bstracing: lib/bstracing
rescript: rescript
checksum: a37dc757a14c57a15fe75a12df52f3d564cc6ef5cacc8356fe70a7d4ab9692736c0fbb56456dff090d8b5b18935a09aed066c623e6764f4c76bed61187e611b7
checksum: 7f12186a84209f586457a60e65755fcdfbcbb503ac805c60ab5132ce4c927bc264c3b851419ed5498ba7dc4066723377bb7453f893f482a0ccd424986d02beba
languageName: node
linkType: hard

Expand Down