[ Fix ] Os.arch should be a function
#34
Merged
+4
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I was thinking your lockfile change looked wrong and CI confirms. You've used an old version of yarn. |
Owner
|
Ah, whatever you did with the install it upgraded packages as well. I couldn't see before with the scale of the lockfile change. The |
Contributor
Author
|
Sorry but what should I do? |
Owner
|
Either merge main into the branch or rebase it. I might have time soon if you can't figure it out! |
Contributor
Author
|
Hope that I'm doing it right! |
Owner
|
It could be partly my fault for not enforcing yarn's frozen lockfile setting. I might be able to adjust it before merge. |
Owner
|
I'm not sure what you did wrong - quite possibly the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binding of
Os.archshould have beunit => stringrather than juststring, as seen in https://nodejs.org/docs/latest/api/os.html#osarch