new: Added 4 urls for all types of screenshots.#1921
Open
alecszaharia wants to merge 2 commits intodevelopfrom
Open
new: Added 4 urls for all types of screenshots.#1921alecszaharia wants to merge 2 commits intodevelopfrom
alecszaharia wants to merge 2 commits intodevelopfrom
Conversation
alecszaharia
force-pushed
the
issue-23680
branch
from
685ce1e to
c93a517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have 4 types of screenshots and we may have clients that may want to store theses files in different locations.
We decide to add 4 types of base urls for screenshots: