Fix USH entity hierarchy: reparent sub-area children + drop event-variant aliases - #268
Merged
Merged
Conversation
…iant aliases Universal Studios Hollywood children whose venue_id is a non-surfaced sub-area (ush.upper_lot / ush.lower_lot) referenced a parent entity that was never emitted, so the sync stranded ~73 of them (dining, plus new rides like Fast & Furious: Hollywood Drift and Bowser Jr. Challenge) in its unresolved-parent queue every cycle. Reparent those onto the ush.ush park; drop CityWalk (ush.cw / uor.cw) children, which have no park to hang off. Also drop per-language / operational variants of a POI: a place flagged is_event=true whose social_sharing_link points at a DIFFERENT canonical place_id (USH "Studio Tour - Mandarin/Spanish", "Studio Tour Last Tram"). Genuine event entities link to themselves (Bowser Jr. Challenge) and are kept. Tests: places.test.ts +8 (reparent, CityWalk exclude, event-variant drop, Bowser-kept guard); full suite 1522 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Universal Studios Hollywood is missing ~73 entities on the wiki — most of its dining, plus new rides including Fast & Furious: Hollywood Drift and Bowser Jr. Challenge. The park shows 41 children when it should have ~100+.
Root cause:
placeToEntitysets each child'sparentIdto its rawvenue_id. For USH those areush.upper_lot/ush.lower_lot/ush.cw, and onlyush.ushis surfaced as a park entity (PARK_PLACE_ID_TO_LEGACY_VENUE_ID). A child pointing at a parent that's never emitted gets stranded in the sync's unresolved-parent queue every cycle and never pushes.Changes
NON_SURFACED_VENUE_PARENT) — Upper/Lower Lot are sub-areas of the singleush.ushpark, so their children reparent ontoush.ush. CityWalk (ush.cw/uor.cw) children are dropped (CityWalk is a dining/shopping district, not a park on the wiki).isEventVariantAlias) — a place withis_event=truewhosesocial_sharing_link?id=points at a different canonical place_id is a per-language / operational duplicate: USH "Studio Tour - Mandarin/Spanish" and "Studio Tour Last Tram". Genuine event entities link to themselves (Bowser Jr. Challenge) and are kept.Validation
src/parks/universal/__tests__/places.test.ts: +8 tests (26 total), including the "event entity that links to itself is kept" guard. Full suite: 1522 pass.