Add ability to run things under valgrind.#1
Open
defuse wants to merge 24 commits intofix-build-warningsfrom
Open
Add ability to run things under valgrind.#1defuse wants to merge 24 commits intofix-build-warningsfrom
defuse wants to merge 24 commits intofix-build-warningsfrom
Conversation
a0b4ef1 to
242fe03
Compare
qa/zcash/performance-measurements.sh
Outdated
|
ACK, and this is good for now, but I think we will want to run valgrind on the whole test suite rather than just the benchmarks. |
Update version and help strings for Zcash Closes zcash#938.
…r creating the '0' argument to the PRF.
…n-at-least Fix a test name bug so that ``make cov-zcash`` correctly runs the ``zcash-gtest`` binary. Fixes zcash#946.
Rename libzerocash to libzcash Rename libzerocash to libzcash in Makefiles and source (C++ namespace) zcash#960
Refactor PRF_gadget to hand responsibility to PRF_addr_a_pk_gadget for creating the '0' argument to the PRF Closes zcash#930
zcash#776 add sha256sum support for Mac OS X
…PourTx` proof field fixed-size.
Enforce first four bits are zero for all spending keys and phi. This introduces a `uint252` to ensure these fields are 252-bits for the PRFs. Closes zcash#899
211754e to
d258d9d
Compare
d258d9d to
fc8c101
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we merge this then we can add a Buildbot waterfall column. Maybe report the total number of errors to speed.z.cash as though it were a performance measure.