Added alac support #562
Open
Added alac support #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bumping this! This is very useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR for Issue #437 "ALAC Output Support"
Changes
Apart from the revelant .cs files, the Settings.default.xml was also changed to include new ConversionPreset Node.
Testing
Self-reviewed changes
Successfully converted multiple .flac file to .m4a files.
The output of the process were .m4a files with the audio encoded as ALAC.
Related issues
None
Additional Notes
Could not implement a bitrate to quality index method as implemented for AAC output type due to lack of information found. However, willing to implement, if found.