Skip to content

Adv search improvements#139

Merged
joshuamotoaki merged 10 commits intomainfrom
adv-search-improvements
Dec 1, 2025
Merged

Adv search improvements#139
joshuamotoaki merged 10 commits intomainfrom
adv-search-improvements

Conversation

@joshuamotoaki
Copy link
Member

Improve the look of the advanced search modal. Make the button more obvious when the search input is focused. Put the time mark control directly on the calendar and save to localStorage. Change icon for export. Add option to sort by capacity and to show capacity on the CourseCards

@joshuamotoaki joshuamotoaki merged commit 7fb1d46 into main Dec 1, 2025
1 check passed
@joshuamotoaki joshuamotoaki deleted the adv-search-improvements branch December 1, 2025 18:47
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +29 to +33
if (browser) {
const saved = localStorage.getItem(TIME_MARKS_KEY);
if (saved !== null) {
$searchSettings.style["Show Time Marks"] = saved === "true";
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid hydrating calendar with mismatched time-mark state

The calendar now reads localStorage and immediately sets $searchSettings.style["Show Time Marks"] during module evaluation. When a user has previously enabled time marks, the client’s initial render includes the extra column while the SSR HTML was generated with the default false value, which causes a hydration mismatch/flash on first load. To keep SSR and client output in sync, load the saved preference in onMount (or delay rendering until after mount) before updating the store.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant