Remove checking for expected fragment size in fragment info tests. #388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The precise size of files in storage is an implementation detail that consumers should not be relying on (besides storage format changes, it may be affected by compression library updates). We remove fragment size comparisons with hardoced numbers from the fragment info tests, and replace them by asserting that they are larger than zero. This is not the first time we have done this (TileDB-Inc/TileDB-Cloud-REST#4761), and there's lots of existing test coverage of the fragment info Go APIs.
shaunrd0
approved these changes
Feb 4, 2026
Member
|
I'm a little sad I am too late to approve. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The precise size of files in storage is an implementation detail that consumers should not be relying on (besides storage format changes, it may be affected by compression library updates).
We remove fragment size comparisons with hardoced numbers from the fragment info tests, and replace them by asserting that they are larger than zero. This is not the first time we have done this (TileDB-Inc/TileDB-Cloud-REST#4761), and there's lots of existing test coverage of the fragment info Go APIs.
Fixes TileDB-Inc/centralized-tiledb-nightlies#65
Fixes https://linear.app/tiledb/issue/CORE-493