Fix Arrow validity buffer lifetime in PyQuery#2294
Merged
kounelisagis merged 4 commits intomainfrom Feb 4, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where
BufferHolderwas created before the validity array was converted to Arrow’s bitmap format. As a result,BufferHolderkept a reference to the original validity array, while the Arrow array's buffer pointer referenced the converted bitmap instead. WhenPyQuerywas deleted, the bitmap memory was freed, leaving a dangling pointer and causing corrupted null values.The bug was already present but mostly hidden - pandas 2.x
to_pandas()typically accessed the buffer before the memory was reclaimed. In pandas 3.0, the conversion path changed and the validity buffer is accessed later, after the freed memory may already have been overwritten, which exposes the corruption.The fix ensures the bitmap is converted first and only then creates the
BufferHolder, so it retains a reference to the correct buffer.Ref CORE-487