VCF-89: Update regions parameter to support type numpy.ndarray#873
Merged
alancleary merged 2 commits intomainfrom Feb 9, 2026
Merged
VCF-89: Update regions parameter to support type numpy.ndarray#873alancleary merged 2 commits intomainfrom
alancleary merged 2 commits intomainfrom
Conversation
Also, regions of type None are now handled explicitly with all other types raising an exception.
Previously untested regions types were added as well.
shaunrd0
approved these changes
Feb 9, 2026
Member
shaunrd0
left a comment
shaunrd0
left a comment
There was a problem hiding this comment.
Thanks! I verified locally that I can run the task graph to completion from CLOUD-2882 using this branch.
Member
Author
|
All CI jobs are passing now that GitHub is stable again. Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All four methods in the Python API that accept a
regionsparameter have been updated:def read_arrow()def read()def export()def read_iter()Tests have been added for each method except for
export(). Apparentlyexport()currently has no test coverage whatsoever so this test will be added during a larger effort to address this issue.