Skip to content

Conversation

@lasofivec
Copy link
Collaborator

@lasofivec lasofivec commented Jul 22, 2022

Following changes:

  • update on the cython speedup notebook
  • added small notebook on the computation of the solid angle subtend by a triangle
  • added tex files on the computations of said solid angle (my version and Didier's, different notations)
  • small changes to better test if a string starts or end with a sub string
  • added reference for the computation for the determination if a 3D angle is reflex or not
  • better print for errors on _vignetting_tools.pyx

@lasofivec lasofivec requested a review from Didou09 July 22, 2022 10:14
@lasofivec lasofivec self-assigned this Jul 22, 2022
@lasofivec
Copy link
Collaborator Author

Just waiting for the tests to pass before updating the PR text (sorry for the messiness)

@lasofivec
Copy link
Collaborator Author

Update done, ready when you are @Didou09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants