Issue673 si units rc #687
Open
Issue673 si units rc #687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
August 24, 2022 18:01
…ion routines more generic
…ctro/_rockingcurve_def.py
…_03_rockingcurve.py
…03_rockingcurve.py
Collaborator
Author
|
Issue fixed in ToFuProject/datastock |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivations:
Use an adequat format to describe the units of the physical quantity involved in the file
tofu/spectro/_rockingcurve_def.pyResults:
Choice to use the library
scipy.constants, in a first time, to allocate the unit in aStringformat.The next step will be to change into an
astropy.unitsformat, more convenient to use (notStringformat)Issues:
Fixes, in devel, issue #673
Examples: