Skip to content
This repository was archived by the owner on Jan 28, 2026. It is now read-only.

Fix isPressed for ButtonConfiguration#537

Open
ffried wants to merge 3 commits intoTokamakUI:mainfrom
sersoft-gmbh:main
Open

Fix isPressed for ButtonConfiguration#537
ffried wants to merge 3 commits intoTokamakUI:mainfrom
sersoft-gmbh:main

Conversation

@ffried
Copy link
Copy Markdown

@ffried ffried commented Jul 19, 2023

This should fix #534.


@State
public var isPressed = false
public var isPressed: (down: Bool, inside: Bool) = (false, false)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about the public api here. It's a breaking change in theory, but AFAIK _Button should only be used internally.

@ffried
Copy link
Copy Markdown
Author

ffried commented Jul 24, 2023

@carson-katri I've fixed a small bug in my first implementation (re-entering the button while holding the mouse down didn't work correctly).
Also, the two workflow runs that previously failed don't seem to be related to my changes.

Copy link
Copy Markdown
Member

@carson-katri carson-katri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@carson-katri carson-katri added the bug Something isn't working label Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Development

Successfully merging this pull request may close these issues.

ButtonStyle configuration.isPressed not updated properly

2 participants