Skip to content

Fixing a JSON crash on saved weapon loadout data #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomGrobbe merged 3 commits into from
Apr 5, 2026
Merged

Fixing a JSON crash on saved weapon loadout data #551

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a09e436
fix(menus/weaponLoadouts) ensuring broken/corrupted JSON doesnt crash…
Gravxd Dec 8, 2025
906f570
Update WeaponLoadouts.cs
TomGrobbe Apr 5, 2026
4e6f9e8
Update WeaponLoadouts.cs
TomGrobbe Apr 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions vMenu/menus/WeaponLoadouts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Collections.Generic;
using System;
using System.Collections.Generic;

using CitizenFX.Core;

Expand Down Expand Up @@ -71,7 +72,18 @@ private Dictionary<string, List<ValidWeapon>> RefreshSavedWeaponsList()

foreach (var save in saves)
{
SavedWeapons.Add(save, JsonConvert.DeserializeObject<List<ValidWeapon>>(GetResourceKvpString(save)));
var kvpValue = GetResourceKvpString(save);
if (!string.IsNullOrEmpty(kvpValue))
{
try
{
SavedWeapons.Add(save, JsonConvert.DeserializeObject<List<ValidWeapon>>(kvpValue));
}
catch (Exception ex)
{
Debug.WriteLine($"[vMenu] Error: Failed to load corrupted saved loadout.\nStacktrace: {ex.StackTrace}\nError message: {ex.Message}\nSaved JSON: {kvpValue}\nSaveName: {save}");
}
}
}

return SavedWeapons;
Expand Down
Loading